fix(step): preserve step.name in simplify() for worker IPC#5563
Closed
gololdf1sh wants to merge 1 commit into
Closed
fix(step): preserve step.name in simplify() for worker IPC#5563gololdf1sh wants to merge 1 commit into
gololdf1sh wants to merge 1 commit into
Conversation
step.simplify() maps name → title, dropping name from the serialized object. Plugins listening to step events in the master process (e.g. retryFailedStep) crash on step.name being undefined. Add name to simplify() output alongside title (kept for BC). Add null-guard in retryFailedStep for edge cases where step.name is undefined on the full Step object (hook steps). Closes testomatio/e2e-tests#139 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Author
|
Closing — wrong approach, replaced by a proper refactor PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
step.simplify()mapsname→title, droppingnamefrom the serialized object sent via IPC from workers to the master process. Any plugin listening to step events in the master process (e.g.retryFailedStep) crashes becausestep.nameisundefined:Root cause
simplify()inlib/step/base.jsreturns{ title: step.name, ... }— the field is renamed fromnametotitle. In sequential mode, plugins receive the fullStepobject with.name. Inrun-workersmode, the worker serializes viasimplify()before IPC, so the master receives an object with.titleonly.Fix
lib/step/base.js— addname: step.nametosimplify()output (alongsidetitlefor backwards compatibility)lib/plugin/retryFailedStep.js— add null-guard for edge cases wherestep.nameis undefined on the full Step object (hook steps)Related
step.name || step.titlefallback in the plugin only)🤖 Generated with Claude Code